Skip to content

Add regex_replace_chars to main.tf#43

Merged
goruha merged 4 commits intomainfrom
allow-repo-name-contains-dots
Apr 21, 2026
Merged

Add regex_replace_chars to main.tf#43
goruha merged 4 commits intomainfrom
allow-repo-name-contains-dots

Conversation

@goruha
Copy link
Copy Markdown
Contributor

@goruha goruha commented Apr 15, 2026 •
edited by coderabbitai Bot
Loading

what

  • Allow repo name to contain dots

why

  • Normalized null-label ID doesn't allow IDs including dot character. Effectively, it tries to change repository name like .github -> github.

references

Summary by CodeRabbit

  • Configuration Updates
    • Repository configuration now includes a new character-pattern parameter to improve validation and handling of allowed/removed characters in repository names and related identifiers, reducing invalid-name errors and improving consistency across tooling and displays.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 36894b42-1c85-4791-9e13-8295cd488a74

📥 Commits

Reviewing files that changed from the base of the PR and between 47f8101 and a83f341.

📒 Files selected for processing (1)
  • src/main.tf
✅ Files skipped from review due to trivial changes (1)
  • src/main.tf
📝 Walkthrough

Walkthrough

The PR adds a single input argument, regex_replace_chars = "/[^a-zA-Z0-9.-]/", to module "repository" in src/main.tf. No other logic, locals, or control flow were modified.

Changes

Cohort / File(s) Summary
Terraform module configuration
src/main.tf		 Added regex_replace_chars = "/[^a-zA-Z0-9.-]/" input to module "repository"; no other edits in the file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibble patterns in the night,
Tidy dots, dashes, letters—just right,
A tiny regex tucked in place,
The repo hops with tidier grace.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly and clearly describes the main change: adding the regex_replace_chars parameter to main.tf.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allow-repo-name-contains-dots

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot requested review from a team April 15, 2026 15:19
@mergify mergify Bot added the triage Needs triage label Apr 15, 2026
@goruha goruha mentioned this pull request Apr 15, 2026
Closed
coderabbitai[bot]
coderabbitai Bot reviewed Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/main.tf`:
- Line 13: The regex in the variable regex_replace_chars currently uses
"/[^.-a-zA-Z0-9]/" which accidentally defines a range from '.' to 'a'; update
the character class so the hyphen is treated literally by placing it at the end
(e.g., "/[^.a-zA-Z0-9-]/") so only dot, hyphen and alphanumeric characters are
allowed; modify the value of regex_replace_chars accordingly, keeping the
surrounding quotes and slashes intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: af1115f6-6289-4ce1-b345-45552e91560c

📥 Commits

Reviewing files that changed from the base of the PR and between ed122dc and bf1cd65.

📒 Files selected for processing (1)
  • src/main.tf

Comment thread src/main.tf Outdated
@goruha @coderabbitai
Update src/main.tf
47f8101 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@mergify mergify Bot added the needs-test Needs testing label Apr 17, 2026
@mergify mergify Bot removed the triage Needs triage label Apr 19, 2026
@mergify mergify Bot requested a review from a team April 19, 2026 16:35
@goruha goruha added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit ebb8858 Apr 21, 2026
14 checks passed
@goruha goruha deleted the allow-repo-name-contains-dots branch April 21, 2026 09:36
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

These changes were released in v1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@RoseSecurity RoseSecurity RoseSecurity approved these changes

Assignees

No one assigned

Labels

needs-test Needs testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goruha @RoseSecurity